Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Inherit projectDir in the temporary kernel#22889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jvasseur commentedMay 24, 2017
This look like a duplicate of#22872 |
aschempp commentedMay 24, 2017
You're right, though#22872 does not correctly handle the |
nicolas-grekas commentedMay 24, 2017
FrameworkBundle 3.3 has a lowest dep on HttpKernel 3.3, which always has the method, so the check is not required. |
aschempp commentedMay 24, 2017
Well but my kernelcould implement the interface and not extend the |
nicolas-grekas commentedMay 24, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hum, you're right. If you care enough about it, I invite you to open a PR against branch 3.3 with the corresponding patch :) |
aschempp commentedMay 24, 2017
Which one would you prefer, the method check or expect the class? |
nicolas-grekas commentedMay 24, 2017
method check to allow having the feature without extending the Kernel class I think |
aschempp commentedMay 26, 2017
see#22921 |
stof commentedMay 26, 2017
@nicolas-grekas I also suggest deprecating having a kernel not implementing it, so that we can add the method in the interface in 4.0 (which will be fine as deprecation, as most people should be extending Kernel anyway, or should just be using HttpKernelInterface otherwise) |
Contrary to all other directories defined in the kernel, the
getProjectDirmethod is not copied to the temporary kernel. This can lead to issues if the method is overridden inAppKernel. Unfortunately, the method is not (and obviously cannot be) in theKernelInterface, somethod_existswas my only option to see if it can be called.