Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Prevent auto-registration of UserPasswordEncoderCommand#22858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ogizanagi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh...Now I understand this issue better indeed. Good catch. 👍
weaverryan commentedMay 22, 2017
👍 Fixes the issue However, I am a bit worried about the PR that introduced this -#20677 - specifically that it adds the EncoderFactoryInterface to the constructor. I think we need to be careful to keep commands lazy - I believe this change will cause that service to be instantiated just by running |
ogizanagi commentedMay 22, 2017
@weaverryan : Which is something that#22734 would solve. (Anyway for this particular case, |
weaverryan commentedMay 22, 2017
@ogizanagi Thanks for pointing me to that :). I'd like to see that get done! 👍 |
nicolas-grekas commentedMay 23, 2017
Thank you@chalasr. |
…EncoderCommand (chalasr)This PR was merged into the 3.3 branch.Discussion----------[SecurityBundle] Prevent auto-registration of UserPasswordEncoderCommand| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22855| License | MIT| Doc PR | n/aAlways registers the command as a service even if no encoders are configured so that it is not auto-registered via reflection.Prevents an irrelevant deprecation when no encoders are configured and, if a day the per-convention command registration is removed, ensures that the command always exists (leading to an exception saying that you have no configured encoder, better than nothing).ping@ogizanagiCommits-------b39b35b Prevent auto-registration of UserPasswordEncoderCommand
Always registers the command as a service even if no encoders are configured so that it is not auto-registered via reflection.
Prevents an irrelevant deprecation when no encoders are configured and, if a day the per-convention command registration is removed, ensures that the command always exists (leading to an exception saying that you have no configured encoder, better than nothing).
ping@ogizanagi