Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] fix multiline block handling#22853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMay 22, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21114,#22105 (comment) |
| License | MIT |
| Doc PR |
| foreach ($this->linesas$line) { | ||
| try { | ||
| $parsedLine = Inline::parse($line,$flags,$this->refs); | ||
| if (isset($line[0]) &&in_array($line[0],array('"',"'"),true)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shorter and easier to read imho:if (isset($line[0]) && ('"' === $line[0] || "'" === $line[0])) {
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 with minor comment
fabpot commentedMay 24, 2017
Thank you@xabbuh. |
This PR was merged into the 3.3 branch.Discussion----------[Yaml] fix multiline block handling| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21114,#22105 (comment)| License | MIT| Doc PR |Commits-------a2079d6 [Yaml] fix multiline block handling