Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Make the simple exception pages match the new style#22838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
xabbuh commentedMay 24, 2017
If that's not too much work, I'd say yes. :) |
deflock commentedMay 27, 2017
Black header with logo may confuse when Debug is used as standalone component. |
fabpot commentedMay 27, 2017
@javiereguiluz Last call for 3.3 :) |
javiereguiluz commentedMay 27, 2017
If we don't want to add the black header ... this should be finished.@deflock has a good point about not adding that header. I'm divided about that. |
fabpot commentedMay 27, 2017
Thank you@javiereguiluz. |
…aviereguiluz)This PR was squashed before being merged into the 3.3 branch (closes#22838).Discussion----------Make the simple exception pages match the new style| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22631| License | MIT| Doc PR | -If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:This PR updates that page to match the style of the rest of exceptions:For comparison, this is how the full exception page looks:---Should I add the small black top header with the Symfony logo too?Commits-------bab4b9c Make the simple exception pages match the new style
This PR was squashed before being merged into the 2.1.x-dev branch (closes#1528).Discussion----------Fix exception hander testIn symfony 3.3.0, the markup of the error wording has been changed.symfony/symfony#228383.2.x`<h1>$title</h1>`3.3.0`<h1>$title</h1>`Therefore, in the symfony 3.3.0 environment, ExceptionHandlerTest fails.```1) Silex \ Tests \ ExceptionHandlerTest :: testExceptionHandlerExceptionNoDebugFailed asserting that '<! DOCTYPE html>...Contains "<h1> Whoops, looks like something went wrong. </h1>".```https://github.com/symfony/symfony/pull/22838/files#diff-5a9ac37e71d14aa261fe6f68848a6277L42I deleted `<h1>` by referring to it.Commits-------69e2771 Fix exception hander test
If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:
This PR updates that page to match the style of the rest of exceptions:
For comparison, this is how the full exception page looks:
Should I add the small black top header with the Symfony logo too?