Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Debug] Deprecate support for stacked errors#22832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| /** | ||
| * @group legacy | ||
| * @expectedDeprecation Support for stacking errors is deprecated since Symfony 3.4 and will be removed in 4.0. | ||
| * @expectedDeprecation Support for unstacking errors is deprecated since Symfony 3.4 and will be removed in 4.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
test are failing, partly because this isn't triggered anymore since the stacking calls are removed from DebugClassLoader
I think the entire test case should be remove
dunno about the other failure yet
rebase needed |
UPGRADE-3.4.md Outdated
| Debug | ||
| ----- | ||
| * support for stacked errors in the `ErrorHanlder` is deprecated and will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ErrorHandler typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed.
UPGRADE-4.0.md Outdated
| @@ -70,6 +70,8 @@ Debug | |||
| * `FlattenException::getTrace()` now returns additional type descriptions | |||
| `integer` and `float`. | |||
| * support for stacked errors in the `ErrorHanlder` has been removed | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ErrorHandler typo
FWIW I spent a little bit yesterday trying to figure out a way to get this failing test to work (mbabker@fde02c6 andmbabker@0e87986 being failed solutions, actually they caused PHP 5.6 to start erroring onmy Travis builds). The only other option I can come up with right now is to just drop it, I don't know what's triggering a parse error but it clearly isn't happening with the stacking gone. |
Thank you@mbabker. |
This PR was merged into the 3.4 branch.Discussion----------[Debug] Deprecate support for stacked errors| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#22804| License | MIT| Doc PR | n/aPer discussion in#22804 this deprecates support for error stacking. //@nicolas-grekasCommits-------04b8b80 Deprecate support for stacked errors
Uh oh!
There was an error while loading.Please reload this page.
Per discussion in#22804 this deprecates support for error stacking. //@nicolas-grekas