Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Finder] Deprecate FilterIterator#22828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:deprec/finder/filter_iteratorMay 21, 2017
Merged
[Finder] Deprecate FilterIterator#22828
nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:deprec/finder/filter_iteratorMay 21, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
ogizanagi commentedMay 21, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #22820 (review) |
| License | MIT |
| Doc PR | N/A |
Member
nicolas-grekas commentedMay 21, 2017
That's for 3.4 |
ContributorAuthor
ogizanagi commentedMay 21, 2017
Oops, indeed. Rebased & re-targeted. |
nicolas-grekas approved these changesMay 21, 2017
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Member
nicolas-grekas commentedMay 21, 2017
The corresponding test case should be marked as legacy |
Member
nicolas-grekas commentedMay 21, 2017
Thank you@ogizanagi. |
nicolas-grekas added a commit that referenced this pull requestMay 21, 2017
This PR was merged into the 3.4 branch.Discussion----------[Finder] Deprecate FilterIterator| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets |#22820 (review)| License | MIT| Doc PR | N/ACommits-------946066c [Finder] Deprecate FilterIterator
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.