Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] remove deprecated features#22821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedMay 21, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
5498aa8 toeaecaddCompare| * @param string|null $context The listener context | ||
| */ | ||
| publicfunctionregisterListener($key,$logoutPath,$csrfTokenId,$csrfParameter,CsrfTokenManagerInterface$csrfTokenManager =null/*, string$context = null*/) | ||
| publicfunctionregisterListener($key,$logoutPath,$csrfTokenId,$csrfParameter,CsrfTokenManagerInterface$csrfTokenManager =null,$context =null) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should bestring $context
1f6e794 tobe387edCompare| You should implement this method yourself in your concrete authenticator. | ||
| * removed the`AccessDecisionManager::setVoters()` method | ||
| * removed the`RoleInterface` | ||
| * added a sixth`$context` argument to the`LogoutUrlGenerator::registerListener()` |
Contributor
ogizanagiMay 21, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This one is already done in#22740 (sorry, hard to track)
nicolas-grekas approved these changesMay 21, 2017
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
be387ed to6a11506CompareMember
nicolas-grekas commentedMay 21, 2017
FC layer missing in fact |
MemberAuthor
xabbuh commentedMay 21, 2017
see#22830 |
6a11506 to97bbf7cComparenicolas-grekas added a commit that referenced this pull requestMay 21, 2017
…buh)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] forward compatibility with Symfony 4| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |#22821 (comment)Commits-------c783e1e forward compatibility with Symfony 4
symfony-splitter pushed a commit to symfony/security-bundle that referenced this pull requestMay 21, 2017
…buh)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] forward compatibility with Symfony 4| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR |symfony/symfony#22821 (comment)Commits-------c783e1e forward compatibility with Symfony 4
Member
nicolas-grekas commentedMay 21, 2017
rebase needed |
97bbf7c to236379aCompare236379a to2397504CompareMemberAuthor
xabbuh commentedMay 21, 2017
rebased, tests pass |
Member
fabpot commentedMay 21, 2017
Thank you@xabbuh. |
fabpot added a commit that referenced this pull requestMay 21, 2017
This PR was merged into the 4.0-dev branch.Discussion----------[Security] remove deprecated features| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |Commits-------2397504 [Security] remove deprecated features
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.