Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Use 0.0.0.0 as the server log command host default.#22768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
lyrixx commentedMay 19, 2017
I did not know 👍 |
lyrixx approved these changesMay 19, 2017
nicolas-grekas approved these changesMay 19, 2017
Member
fabpot commentedMay 19, 2017
Thank you@ChadSikorra. |
fabpot added a commit that referenced this pull requestMay 19, 2017
…ikorra)This PR was merged into the 3.3 branch.Discussion----------Use 0.0.0.0 as the server log command host default.| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | -| Fixed tickets | -| License | MITThis fixes the `server:log` command on Windows when run with default settings. The current setting `0` has no meaning on Windows, and `0.0.0.0` is the standard "listen on all addresses/interfaces", so should be the most compatible. It works on both Linux and Windows for me this way.I mentioned this in another PR where the logger config has the same issue on Windows:symfony/symfony-standard#1077Commits-------3fcc810 Use 0.0.0.0 as the server log host default.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
server:logcommand on Windows when run with default settings. The current setting0has no meaning on Windows, and0.0.0.0is the standard "listen on all addresses/interfaces", so should be the most compatible. It works on both Linux and Windows for me this way.I mentioned this in another PR where the logger config has the same issue on Windows:
symfony/symfony-standard#1077