Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DI] Remove deprecated dumping an uncompiled container#22764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
missing CHANGELOG updates in components (please check any your other PRs also if any) |
@nicolas-grekas like sohttps://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/CHANGELOG.md#300 can be done at once for all components right? |
or like so:https://github.com/symfony/symfony/pull/22779/files |
| $this->startClass($options['class'], $options['base_class'], $options['namespace']). | ||
| $this->addFrozenConstructor(). | ||
| $this->addFrozenCompile(). | ||
| $this->addFrozenIsCompiled(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest renaming these, remove "Frozen"
(+ rebase meanwhile :) )
Ready! |
Thank you@ro0NL. |
… (ro0NL)This PR was merged into the 4.0-dev branch.Discussion----------[DI] Remove deprecated dumping an uncompiled container| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | should be| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!--highly recommended for new features-->See#20634Commits-------c1c525c [DI] Remove deprecated dumping an uncompiled container
Uh oh!
There was an error while loading.Please reload this page.
See#20634