Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security][Serializer][DI] Add new arguments typehints in preparation for 4.0#22757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.3fromogizanagi:fix/security/new_arg_typehintMay 21, 2017
Merged
[Security][Serializer][DI] Add new arguments typehints in preparation for 4.0#22757
nicolas-grekas merged 1 commit intosymfony:3.3fromogizanagi:fix/security/new_arg_typehintMay 21, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
stof approved these changesMay 18, 2017
nicolas-grekas approved these changesMay 19, 2017
xabbuh approved these changesMay 19, 2017
Member
nicolas-grekas commentedMay 20, 2017
would mind fixing them all here in 3.3? |
ContributorAuthor
ogizanagi commentedMay 20, 2017
Sure |
Member
nicolas-grekas commentedMay 21, 2017
Thank you@ogizanagi. |
nicolas-grekas added a commit that referenced this pull requestMay 21, 2017
…n preparation for 4.0 (ogizanagi)This PR was merged into the 3.3 branch.Discussion----------[Security][Serializer][DI] Add new arguments typehints in preparation for 4.0| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22743 (review)| License | MIT| Doc PR | N/ASee#22743 (review) discussion for the motivations.Commits-------b973b30 [Security][Serializer][DI] Add new arguments typehints in preparation for 4.0
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See#22743 (review) discussion for the motivations.