Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Remove deprecated container injections and compiler passes#22749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f679e43 to8b0ccf6CompareMember
nicolas-grekas commentedMay 18, 2017
rebase needed to see tests green |
MemberAuthor
chalasr commentedMay 18, 2017
done, thanks |
stof requested changesMay 18, 2017
| */ | ||
| publicfunction__construct(ContainerInterface$container,MessageSelector$selector,$defaultLocale =null,array$loaderIds =array(),array$options =array()) | ||
| { | ||
| // BC 3.x, to be removed in 4.0 along with the $defaultLocale default value |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you forgot to remove the default value
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed
Member
nicolas-grekas commentedMay 20, 2017
missing CHANGELOG updates in components (please check any your other PRs also if any) |
3b54859 toc785d51CompareMemberAuthor
chalasr commentedMay 20, 2017
CHANGELOG entries added |
42c7aec to455b6a0Compare| * @throws InvalidArgumentException | ||
| */ | ||
| publicfunction__construct(ContainerInterface$container,MessageSelector$selector,$defaultLocale =null,array$loaderIds =array(),array$options =array()) | ||
| publicfunction__construct(ContainerInterface$container,MessageSelector$selector,$defaultLocale,array$loaderIds =array(),array$options =array()) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it looks like the docblock is not up to date - and we could add a "string" type hint meanwhile here
| * Removed`ValidateWorkflowsPass` | ||
| * The default`type` option of the`framework.workflows.*` configuration entries is`state_machine` | ||
| *[BC BREAK] removed`AddConsoleCommandPass`,`AddConstraintValidatorsPass`, |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i'm not sore we need all these bc break prefixes, I'd remove them
MemberAuthor
chalasr commentedMay 21, 2017
@nicolas-grekas comments addressed |
Member
nicolas-grekas commentedMay 21, 2017
@chalasr would you mind opening a PR to fix that doc block in 3.3 (I guess)? |
Member
nicolas-grekas commentedMay 21, 2017
Thank you@chalasr. |
nicolas-grekas added a commit that referenced this pull requestMay 21, 2017
…sses (chalasr)This PR was merged into the 4.0-dev branch.Discussion----------Remove deprecated container injections and compiler passes| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets | ~~#21451#21625#21284#22010~~#22805| License | MIT| Doc PR | n/aCommits-------16a2fcf Remove deprecated container injections and compiler passes
MemberAuthor
chalasr commentedMay 21, 2017
nicolas-grekas added a commit that referenced this pull requestMay 21, 2017
…halasr)This PR was merged into the 3.3 branch.Discussion----------Add missing doc param & deprecation changelog entries| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22749 (comment)| License | MIT| Doc PR | n/aCommits-------7b14d4f Add missing doc param & deprecation changelog entries
nicolas-grekas added a commit that referenced this pull requestMay 24, 2017
This PR was merged into the 4.0-dev branch.Discussion----------[FrameworkBundle] Remove deprecated code| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | yes| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR | N/ARemove deprecated code in the FrameworkBundle (except compiler passes and stuff already removed by#22749): * Removed `cache:clear` warmup part along with the `--no-optional-warmers` option. * Removed core form types services registration when unnecessary * Removed `framework.serializer.cache` option and `serializer.mapping.cache.apc`, `serializer.mapping.cache.doctrine.apc` services * Removed `ConstraintValidatorFactory::$validators` and `ConstraintValidatorFactory::$container` protected properties * Removed class parameters related to routing * Removed absolute template paths support in the template name parserCommits-------531156e [FrameworkBundle] Remove deprecated code
Merged
xabbuh added a commit that referenced this pull requestJan 1, 2018
nicolas-grekas added a commit that referenced this pull requestJan 2, 2018
* 4.0: (23 commits) Clean up Update return type in docblock. PHP CS Fixer: no need to exclude xml and yml files PHP CS Fixer: no need to exclude json file [#22749] fix version in changelog Update LICENSE year... forever fixed some deprecation messages fixed CS Fixes for Oracle in PdoSessionHandler fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages Remove dead code [TwigBundle/Brige] catch missing requirements to throw meaningful exceptions [DI] fix CS [HttpKernel] Call Response->setPrivate() instead of sending raw header() when session is started [FrameworkBundle] Make cache:clear "atomic" and consistent with cache:warmup Suggest to write an implementation if the interface cannot be autowired [Debug] Skip DebugClassLoader checks for already parsed files ...
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull requestMar 25, 2018
* 4.0: (23 commits) Clean up Update return type in docblock. PHP CS Fixer: no need to exclude xml and yml files PHP CS Fixer: no need to exclude json file [symfony#22749] fix version in changelog Update LICENSE year... forever fixed some deprecation messages fixed CS Fixes for Oracle in PdoSessionHandler fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages fixed some deprecation messages Remove dead code [TwigBundle/Brige] catch missing requirements to throw meaningful exceptions [DI] fix CS [HttpKernel] Call Response->setPrivate() instead of sending raw header() when session is started [FrameworkBundle] Make cache:clear "atomic" and consistent with cache:warmup Suggest to write an implementation if the interface cannot be autowired [Debug] Skip DebugClassLoader checks for already parsed files ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
#21451#21625#21284#22010#22805