Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle][Security][Finder] Remove deprecated code paths#22740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromogizanagi:rm_deprecated_code
May 21, 2017
Merged

[SecurityBundle][Security][Finder] Remove deprecated code paths#22740

nicolas-grekas merged 1 commit intosymfony:masterfromogizanagi:rm_deprecated_code
May 21, 2017

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagiogizanagi commentedMay 18, 2017•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?yes
Deprecations?no
Tests pass?yes
Fixed tickets1b600b0,366aefd,5b7fe85
LicenseMIT
Doc PRN/A

Removing my own deprecated stuff from 4.0 :)

chalasr and yceruto reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

rebase needed to see tests green

@ogizanagi
Copy link
ContributorAuthor

Aaaand, green it is.

* @param string|null $context The listener context
*/
publicfunctionregisterListener($key,$logoutPath,$csrfTokenId,$csrfParameter,CsrfTokenManagerInterface$csrfTokenManager =null/*,$context = null*/)
publicfunctionregisterListener($key,$logoutPath,$csrfTokenId,$csrfParameter,CsrfTokenManagerInterface$csrfTokenManager =null,string$context =null)
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Related PR to add the typehint in 3.3:#22757

@nicolas-grekas
Copy link
Member

could the commit message be made more explicit? any CHANGELOG missing an update?

@ogizanagiogizanagi changed the titleRemoving some deprecated stuff[SecurityBundle][Security][Finder] Remove deprecated code pathsMay 20, 2017
@ogizanagi
Copy link
ContributorAuthor

ogizanagi commentedMay 20, 2017•
edited
Loading

I changed the commit message and description and added CHANGELOG entries.

- [Finder] Removed `ExceptionInterface`- [SecurityBundle] remove `UserPasswordEncoderCommand` BC layer- [Security] remove `LogoutUrlGenerator::registerListener` BC layer
@nicolas-grekasnicolas-grekas merged commitda202fe intosymfony:masterMay 21, 2017
nicolas-grekas added a commit that referenced this pull requestMay 21, 2017
…ode paths (ogizanagi)This PR was merged into the 4.0-dev branch.Discussion----------[SecurityBundle][Security][Finder] Remove deprecated code paths| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | yes| Deprecations? | no| Tests pass?   | yes| Fixed tickets |1b600b0,366aefd,5b7fe85| License       | MIT| Doc PR        | N/ARemoving my own deprecated stuff from 4.0 :)Commits-------da202fe [SecurityBundle][Security][Finder] Remove deprecated code paths
@ogizanagiogizanagi deleted the rm_deprecated_code branchMay 21, 2017 13:09
@fabpotfabpot mentioned this pull requestOct 19, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp