Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Sessions: configurable "use_strict_mode" option for NativeSessionStorage#22730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMay 27, 2017
You will also need to update the XML schema definition. |
MacDada commentedJun 2, 2017
@xabbuh ? |
xabbuh commentedJun 3, 2017
What I mean is that you will have to updatethis block to allow to use the new option in XML configs. |
fabpot commentedJun 14, 2017
I think being able to configure all options in the config make sense (rebase on current 2.7 as we've just added 4 new options from 7.1). Doing that in a somewhat automated way would be even better if possible. |
MacDada commentedJun 15, 2017
I don't know how could it be automated. |
793474c to90e192eCompareMacDada commentedJun 16, 2017
I rebased against 2.7 and squashed my commits into one. |
fabpot commentedJun 18, 2017
Thank you@MacDada. |
… option for NativeSessionStorage (MacDada)This PR was merged into the 2.7 branch.Discussion----------[FrameworkBundle] Sessions: configurable "use_strict_mode" option for NativeSessionStorage| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITIt is currently not possible to configure the `use_strict_mode` option for `NativeSessionStorage` in a proper manner.The reason of this PR:#22352 (comment)It could be considered a new feature, but I wish it wouldn't, as I don't want to do any ugly hacking to get it working.What else could be done?* implement more options from `NativeSessionStorage` in the config?* get rid of duplication somehow (maybe a static method in `NativeSessionStorage` that would return the option list and could be used in `FrameworkExtension`?)* update `FrameworkExtensionTest`?* update `ConfigurationTest`?* update [the docs](https://symfony.com/doc/current/reference/configuration/framework.html#session)?I'm willing to do those if decided.Commits-------90e192e Sessions: configurable "use_strict_mode" option for NativeSessionStorage
It is currently not possible to configure the
use_strict_modeoption forNativeSessionStoragein a proper manner.The reason of this PR:#22352 (comment)
It could be considered a new feature, but I wish it wouldn't, as I don't want to do any ugly hacking to get it working.
What else could be done?
NativeSessionStoragein the config?NativeSessionStoragethat would return the option list and could be used inFrameworkExtension?)FrameworkExtensionTest?ConfigurationTest?I'm willing to do those if decided.