Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Adding autowire alias for AuthenticationUtils#22701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <serviceid="security.authentication_utils"class="Symfony\Component\Security\Http\Authentication\AuthenticationUtils"public="true"> | ||
| <argumenttype="service"id="request_stack" /> | ||
| </service> | ||
| <serviceid="Symfony\Component\Security\Http\Authentication\AuthenticationUtils"alias="security.authentication_utils" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The alias should be private (that's how all the other ones are)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks to you - itis private :). This file has<defaults public="false" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Haha indeed :)
weaverryan commentedMay 13, 2017
See#22708 |
AuthenticationUtils is a public service (used commonly in your
loginAction), so it should be autowireable.We might need to do a full audio of public services to add aliases. Since we're moving in the direction of type-based autowiring, these aliases are sort of the new "public" - it's the list of things you're "supposed" to use.