Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Fix errors not rethrown even if not handled by console.error listeners#22690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromchalasr:console-error-handling
May 11, 2017

Conversation

@chalasr
Copy link
Member

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#22678
LicenseMIT
Doc PRn/a

#22261 has been squashed while revisiting error handling, this fixes it again while keeping latest changes intact.

code

publicfunctionexecute(InputInterface$input,OutputInterface$output) {$this->barr();}publicfunctionbar() { }

before
before

after
after

ogizanagi reacted with thumbs up emoji
@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit75f098f intosymfony:2.7May 11, 2017
fabpot added a commit that referenced this pull requestMay 11, 2017
…onsole.error listeners (chalasr)This PR was merged into the 2.7 branch.Discussion----------[Console] Fix errors not rethrown even if not handled by console.error listeners| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#22678| License       | MIT| Doc PR        | n/a#22261 has been squashed while revisiting error handling, this fixes it again while keeping latest changes intact.__code__```phppublic function execute(InputInterface $input, OutputInterface $output) {    $this->barr();}public function bar() { }```__before__![before](http://image.prntscr.com/image/38aa3b46fed6439ead693908ab104fb3.png)__after__![after](http://image.prntscr.com/image/071322bfa52247c6a02eac6ef9d8284a.png)Commits-------75f098f Fix errors not rethrown even if not handled by console.error listeners
@chalasrchalasr deleted the console-error-handling branchMay 11, 2017 17:14
@ciaranmcnulty
Copy link
Contributor

Thanks@chalasr, this fixes the issue we had on PhpSpec

@fabpotfabpot mentioned this pull requestMay 17, 2017
This was referencedMay 29, 2017
@FloatingMaster
Copy link

This pr breaks handling php \Throwable exceptions

see#18484

@chalasr
Copy link
MemberAuthor

I don't get what you mean. Please open a new issue, I find no comments from you in the thread which is also closed thus won't be tracked

@chalasr
Copy link
MemberAuthor

chalasr commentedJul 3, 2017•
edited
Loading

(and the linked thread is older than this PR, not related)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chalasr@fabpot@ciaranmcnulty@FloatingMaster@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp