Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Adding the extension XML#22676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Pierstoval commentedMay 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
PR name should be prepended with [FrameworkBundle], for the rest I'm 👍 |
flug commentedMay 9, 2017
Oh right, I redid this pull request on FrameworkBundlesymfony/framework-bundle#15 |
Pierstoval commentedMay 9, 2017
Don't make PR onsymfony/framework-bundle#15, this is a read-only split of the full-stack repo. This#22676 PR is good, you just have to rename the PR and add [FrameworkBundle] at the beginning of it so it can be tagged properly and fabbot.io doesn't complain 🙂 |
required by XmlUtils and not installed by default
fabpot commentedMay 9, 2017
Thank you@flug. |
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#22676).Discussion----------[FrameworkBundle] Adding the extension XML| Q | A| ------------- | ---| Branch? | <3.3| Bug fix? | yes| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks? | no| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->This pull request is referenced on <!--- Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the master branch.- Please fill in this template according to the PR you're about to submit.- Replace this comment by a description of what your PR is solving.-->Commits-------6fe2ad0 [FrameworkBundle] Adding the extension XML
xabbuh commentedMay 10, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I am not sure about this change. We did not explicitly require other PHP standard extensions in the past, did we? And if we were to do this for the FrameworkBundle, we should IMO do the same for the other bundles too. |
This PR was merged into the 2.7 branch.Discussion----------require the XML PHP extension| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22676 (comment),symfony/symfony-standard#1099| License | MIT| Doc PR |I suggest to either revert#22676 or to be consistent and require the XML extension in all bundles as well as in the `symfony/symfony` package.Commits-------032e654 require the XML PHP extension
This pull request is referenced on