Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Security] Fix TraceableAccessDecisionManager / DebugAccessDecisionManager BC layer#22664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromogizanagi:fix/security/traceable_acc_dec_mgr_bc_layerMay 11, 2017
Merged
[Security] Fix TraceableAccessDecisionManager / DebugAccessDecisionManager BC layer#22664
fabpot merged 1 commit intosymfony:masterfromogizanagi:fix/security/traceable_acc_dec_mgr_bc_layerMay 11, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedMay 11, 2017
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestMay 11, 2017
…sDecisionManager BC layer (ogizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[Security] Fix TraceableAccessDecisionManager / DebugAccessDecisionManager BC layer| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22657 (comment)| License | MIT| Doc PR | N/ASame as#22657 for the renaming of `DebugAccessDecisionManager` into `TraceableAccessDecisionManager`. Indeed, I think we also require to redeclare the old `DebugAccessDecisionManager` for composer `classmap-authoritative` autoloading strategy & classmap dumper.AppVeyor failures unrelated.Edit: Re-thinking about it, it's probably not very common to dump the classmap and use the `classmap-authoritative` strategy when using those classes... That's to say: in debug mode/dev env. So it may be the reason why the class wasn't redeclared on contrary of `DefinitionDecorator`.Commits-------5b123b9 [Security] Fix TraceableAccessDecisionManager / DebugAccessDecisionManager BC layer
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Same as#22657 for the renaming of
DebugAccessDecisionManagerintoTraceableAccessDecisionManager. Indeed, I think we also require to redeclare the oldDebugAccessDecisionManagerfor composerclassmap-authoritativeautoloading strategy & classmap dumper.AppVeyor failures unrelated.
Edit: Re-thinking about it, it's probably not very common to dump the classmap and use the
classmap-authoritativestrategy when using those classes... That's to say: in debug mode/dev env. So it may be the reason why the class wasn't redeclared on contrary ofDefinitionDecorator.