This will break stuff.. yes :)

For being a bootstrap theme it makes sense to add the proper classes by definition, otherwise it wouldnt be a valid bootstrap theme. Meaning you need another extension point ;-) Perhaps refactor to something like#21751 so that classes are put in a separate block, which you can override.

That still seems rather bizarre to me. Here's the basic issue:

Say I have

class MyFormType extends AbstractType {    public function buildForm(FormBuilderInterface $builder, array $options)    {        $builder->add('something',null, ['attr'=>['class'=>'some classes']]);    }}

I don't get an input with I get. I cannot in my form set the class. I agree that bydefault, the class should be added, but I disagree that it should be added to any input that has any class set, since as a dev I know what should be there.

I do realize that this will break others, but it really seems very bizarre to override a form theme so that my classes are applied.

I don't get an input with I get. I cannot in my form set the class.

I don't understand this. Your class will be set anyway. It's just theform-control class is present too. So what's the issue with it?

Merging the PR as is cannot be done as it will break every other use where people just want to add additional classes.

I realize this can't be merged as is for many reasons.

Here's the issue. If I specify a form class I have no way tonot have the form control class. This may seem insignificant but having to override a form theme to simply remove a class is the wrong solution in my opinion. I can still use the bootstrap theme (css wise not symfony form theme) without having form-control on the input. For example the specific reason I found this issue is because we have a theme built on top of bootstrap. It has a bunch of input sizing classes, they need to be applied without form-control to work. I can't do that without overriding the theme. Unfortunately I think the way the default class is applied for this theme is wrong and changing it would cause a BC but really, creating a form theme is just weird to solve an issue that the form system should just do.

You can still override Bootstrap's CSS for theform-control class in your own CSS files to fit your needs.

yes - I completely and totally understand there are multiples ways around this issue. We've worked around it internally already. You can probably close this - though I still think this should be fixed in a future backwards breaking way/branch. Its nonsense to override it in the other places to fix this.

I filed this bug because when I do this (regardless of the theme involved):

  $builder->add('something',null,['attr'=>['class'=>'some classes']]);

I think it is a bug to getanything but 'some classes' in the output. Its nice to have defaults, but it seems wrong thatexplicitly setting an option doesn'tget exactly that option.

IMHO it's not a bug. The theme is specific to a bootstrap framework and the framework specifies how the theme should look like.

The theme provides thedefaults. If you take bootstrap and build a site with it, you arenot required toalways use class=form-control on your inputs. If you have a situation for whatever reason where you want fine grained control of the class used on the input. It is logical that you would set the class on the symfony form via the attr->class entry. The fact that you cannot remove a class when you explicitly set the class is the issue. The theme has adefault yes, but the bug I am reporting is that Icannot remove that without doing crazy amounts of work for overriding themes. If I have a form with 3 inputs and one of them can't have the form-control class applied I have to jump through crazy hoops to override the class Iset in the form for thatone field. That is a bug IMO.

Well, there are ways to achieve your goal. Either by writing CSS that does not need the class to be absent or by creating a custom theme that extends the built-in one and overrides this widget. Introducing a new config option (which we would need to be backward compatible) IMO is to much work in core to support this edge case.

I still think you either opt-in or opt-out from form theming; if you opt-in and use bootstrap as a theme; this means inputs needs a form-control class (from the theme pov).

It's weird only one field should follow a different theme; but in that case there are solutions already (like@xabbuh mentioned).

If overriding becomes a mess we could stil make themes more flexible like mentioned in#22622 (comment)

alrighty

2nd thing that's documented is that if you need this for one field only you can overwrite it on the spot (same template). or prepare the external template file and include it where needed. IMO you are over-complicating things.