Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[EventDispatcher] fix getting priorities of listeners during dispatch#22568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
stof commentedApr 28, 2017
I think a better solution is to fix the implementation of |
ContributorAuthor
dmaicher commentedApr 28, 2017
@stof you are right 👍 I pushed a new version. |
stof approved these changesApr 28, 2017
Member
nicolas-grekas commentedApr 28, 2017
Thank you@dmaicher. |
nicolas-grekas added a commit that referenced this pull requestApr 28, 2017
…ng dispatch (dmaicher)This PR was merged into the 3.2 branch.Discussion----------[EventDispatcher] fix getting priorities of listeners during dispatch| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22520| License | MIT| Doc PR | -The WebProfiler collects listener info during dispatching the `kernel.terminate` event which caused issues while retrieving priorities as the wrappers are registered instead of the real listeners.Commits-------79b71c0 [EventDispatcher] fix getting priorities of listeners during dispatch
Merged
nicolas-grekas added a commit that referenced this pull requestMay 2, 2017
This PR was merged into the 3.2 branch.Discussion----------[EventDispatcher] fix merge of#22541 from 2.8| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This cleans up a test case that was merged from 2.8 into 3.2 here:824dc8b@fabpot due to different implementations I created 2 PR's:2.8:#225413.2:#22568So the 2.8 merge into 3.2 of my change-set introduced some unused variable `$isWrapped` here:824dc8b#diff-af3c4fbca8bb77957c00087543ae5a4dR113This PR just cleans it up and also removes the data provider 😉Commits-------f67eba8 [EventDispatcher] fix merge of#22541 from 2.8
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebProfiler collects listener info during dispatching the
kernel.terminateevent which caused issues while retrieving priorities as the wrappers are registered instead of the real listeners.