Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Add missing normalizer options constants#22555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromogizanagi:fix/3.3/serializer/normalizer_constsApr 29, 2017
Merged
[Serializer] Add missing normalizer options constants#22555
fabpot merged 1 commit intosymfony:masterfromogizanagi:fix/3.3/serializer/normalizer_constsApr 29, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesApr 28, 2017
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Member
fabpot commentedApr 29, 2017
Thank you@ogizanagi. |
fabpot added a commit that referenced this pull requestApr 29, 2017
…gizanagi)This PR was merged into the 3.3-dev branch.Discussion----------[Serializer] Add missing normalizer options constants| Q | A| ------------- | ---| Branch? | master (3.3)| Bug fix? | not really| New feature? | yesish, but for 3.3 as those options were added on this branch and not released yet| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22537 (comment)| License | MIT| Doc PR | N/AAs seen in#22537 (comment).@dunglas : I'm not sure about the exposing the `key_type` option as a constant in `ArrayDenormalizer`/`AbstractObjectNormalizer`, as it looks more or less like a detail of the AbstractObjectNormalizer implementation, but anyway it should be in 3.2 if we add it, so I haven't included it here.However, I wonder if this option shouldn't directly accept a string too, rather than just a `Symfony\Component\PropertyInfo\Type` instance if we want to consider this option "public"?Commits-------b0c414f [Serializer] Add missing normalizer options constants
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As seen in#22537 (comment).
@dunglas : I'm not sure about the exposing the
key_typeoption as a constant inArrayDenormalizer/AbstractObjectNormalizer, as it looks more or less like a detail of the AbstractObjectNormalizer implementation, but anyway it should be in 3.2 if we add it, so I haven't included it here.However, I wonder if this option shouldn't directly accept a string too, rather than just a
Symfony\Component\PropertyInfo\Typeinstance if we want to consider this option "public"?