Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Allow Upper Case property names in ObjectNormalizer#22550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:2.8frominsekticid:patch-object-serializer-upper-case-attributeApr 29, 2017
Merged
Allow Upper Case property names in ObjectNormalizer#22550
fabpot merged 1 commit intosymfony:2.8frominsekticid:patch-object-serializer-upper-case-attributeApr 29, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Q | A| ---------------- | -----| Bug report? | yes| Feature request? | no| BC Break report? | yes| RFC? | no| Symfony version | 2.8.19Same problem that has been fixed here#22265and hereapi-platform/core#1037ObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible```phpclass Entity { protected $Id; public function getId() { return $this->Id; }}```
dunglas approved these changesApr 27, 2017
Member
fabpot commentedApr 29, 2017
Thank you@insekticid. |
fabpot added a commit that referenced this pull requestApr 29, 2017
…ticid)This PR was merged into the 2.8 branch.Discussion----------Allow Upper Case property names in ObjectNormalizer| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | yes| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22547| License | MITSame problem that has been fixed here#22265and hereapi-platform/core#1037ObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible```phpclass Entity { protected $Id; public function getId() { return $this->Id; }}```Commits-------b2b4faa Allow Upper Case property names in ObjectNormalizer
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same problem that has been fixed here#22265
and hereapi-platform/core#1037
ObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible