Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] Revert auto configuring form types as service#22503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@HeahDude
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets~
LicenseMIT
Doc PR~

I've just reviewed#22234. I don't think we should enforce Form types as services, this is not a requirement unless then need injection, so we should let Devs configure them when needed as it is done currently.

@sstok
Copy link
Contributor

sstok commentedApr 23, 2017•
edited
Loading

Wait. Isn't this only done when the Type is already a service? It's about automatically tagging (explicitly registered/auto wired) services. Not about finding all autoloadable classes that implement a specific interface.

@HeahDude
Copy link
ContributorAuthor

@sstok You're right, thanks! Sorry for the noise.

sstok reacted with thumbs up emojisstok reacted with laugh emoji

@HeahDudeHeahDude deleted the fix/auto_conf-form branchApril 23, 2017 09:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeahDude@sstok@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp