@dunglas (sorry) in my and you test:

<document index="182077241760011681341821060401202210011000045913000000017100">Name</document>

index attribute is not a number, but very similar.

After converting to a float, you lost data...

happy to help

my name is dungles

index attribute is not a number, but very similar.

Sorry@valisj I'm not sure to understand what you mean here

var_dump(is_numeric('182077241760011681341821060401202210011000045913000000017100'));bool(true)

After converting to a float, you lost data...

Indeed, but as with theJsonEncoder (and as usually with programming languages). But as you pointed out in the issue, it's problematic that things looking like numbers are automatically converted. It should be an opt-in feature (through a context flag). It's a BC break but it's safer and will avoid unexpected behaviors like this one. ping @symfony/deciders

Thank you@dunglas.

@fabpot Nooooo...
Now XmlEncoder never return data from XML without distortion.
Test in this PR incorrect!!!

@dunglas do not compare with JSON. In JSON has number and string tokens, xml has only string.

$doc ='{    "one": "182077241760011681341821060401202210011000045913000000017100",    "two": 182077241760011681341821060401202210011000045913000000017100}';var_dump($jsonEncoder->decode($doc,'json'));

array(2) {  ["one"]=>  string(60)"182077241760011681341821060401202210011000045913000000017100"  ["two"]=>  float(1.8207724176001E+59)}

It all depends on how the data is encoded.
But, in XML we can't control as encoding data. Now we will never get the original data...

thx...

Basically what this tests is182077241760011681341821060401202210011000045913000000017100 === (int) '182077241760011681341821060401202210011000045913000000017100' which will work because the string is converted to an int, and so you bypass the overflow.

But it doesn't contain the exact same input data! 😱 not to mention that02471 is also numeric but not an integer.

@dunglas In JSON it's only converted when the value is an actual integer.

https://3v4l.org/Zbag5

• var_dump(json_decode('{"he": "02471"}')); givesobject(stdClass)#1 (1) { ["he"]=> string(5) "02471" }

https://3v4l.org/34giH

• var_dump(json_decode('{"he": 182077241760011681341821060401202210011000045913000000017100}'));:object(stdClass)#1 (1) { ["he"]=> float(1.8207724176001E+59) }

We cannot prevent something from being a string, but we shouldn't blindly convert convert any number to an integer as this will break for octal and international phone numbers 😃

@sstok I'm experiencing a similar issue.

I have an attribute with a value of00000018 and it's being converted into a float as18 instead of00000018 like I need it to be. I don't see any easy way of getting the original value.

@dunglas any suggestions?