Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added the docs for WebServerBundle#22471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketssymfony/symfony-docs#7325
LicenseMIT
Doc PR-

This initial doc is needed to add the WebServerBundle to this page:https://symfony.com/doc/bundles/

ogizanagi, linaori, robfrawley, and apfelbox reacted with thumbs up emoji
@stof
Copy link
Member

We never put documentation in the main Symfony repo. This should go in symfony-docs


``--filter``
Any `ExpressionLanguage`_ compatible expression used to filter the log
messages before displaying them (e.g. ``"level > 200 or channel in [\'app\', \'doctrine\']"``).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you should document the available variables

@javiereguiluz
Copy link
MemberAuthor

If we don't document this in the bundle's repository, then we won't be able to display it onhttps://symfony.com/doc/bundles/

Besides, other bundles already have short docs in this repo:https://github.com/symfony/monolog-bundle/blob/master/Resources/doc/index.rst andhttps://github.com/symfony/swiftmailer-bundle/blob/master/Resources/doc/index.rst

yceruto reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas added this to the3.3 milestoneApr 20, 2017
@weaverryan
Copy link
Member

Ah, so the difference between this bundle andthose bundles is that they are in separate repositories. But, since we're moving towards not includingsymfony/symfony, it does indeed make more sense to begin documenting the individual bundles as if they were separated.

So, 👍 in theory, but I kinda doubt that Fabien will want big docs like this living in this repo. Would it be a better idea (for bundles that are actuallyinside symfony/symfony) to add abundles/ directory insymfony/symfony-docs and updatesymfony.com to be able to pull from that?

Nek- and stephanvierkant reacted with thumbs up emoji

@stof
Copy link
Member

I like the idea of@weaverryan

@fabpot
Copy link
Member

I've just pushed an alternative in#22607. I think it's better to not duplicate documentation. Commands should be documented so that help is available on the CLI. I've also reused the description of the component in the README. That should be enough I think.

@robfrawley
Copy link
Contributor

robfrawley commentedMay 2, 2017
edited
Loading

@fabpot Basic usage and installation should be documented on the Symfony website under thebundles/ path, regardless of the completeness of the CLI documentation, IMHO. Especially as more and more items are split into their own packages (regardless of the fact that they all actually exist in a single root repo). What did you think of creating a bundle documentation root withinsymfony-docs thatsymfony.com learns to also pull from?

@fabpot
Copy link
Member

@robfrawley Installation is a no-brainer with Flex. And there is no documentation except the CLI commands as the bundle is just about that. I don't see the point.

fabpot added a commit that referenced this pull requestMay 3, 2017
This PR was merged into the 3.3-dev branch.Discussion----------Add some missing docs for the web server bundle| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | n/a| License       | MIT| Doc PR        | n/aThis is an alternative to#22471Commits-------987a681 added some missing docs for the web server bundle
@fabpotfabpot closed thisMay 3, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

7 participants

@javiereguiluz@stof@weaverryan@fabpot@robfrawley@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp