Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Review console.ERROR related behavior#22441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| * @author James Halsall <james.t.halsall@googlemail.com> | ||
| * @author Robin Chalas <robin.chalas@gmail.com> | ||
| * | ||
| * @deprecated since version 3.3, to be removed in 4.0. Use ErrorListener instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This listener has been added in 3.3 (#21003), can be renamed directly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fixed, thanks
nicolas-grekas commentedApr 25, 2017
👍 also :) |
| returnparent::getException(); | ||
| $r =new \ReflectionProperty($this->error,'code'); | ||
| $r->setAccessible(true); | ||
| $r->setValue($this->error,$this->exitCode); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why altering the exception ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because the other part of the exception handling uses getCode as the way to set the exit status code from an exception
| parent::__construct($command,$input,$output); | ||
| $this->exception =$exception; | ||
| $this->setException($exception); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
useless change
fabpot commentedApr 26, 2017
Thank you@nicolas-grekas. |
…as-grekas)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Review console.ERROR related behavior| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -This PR is a follow up of#18140 that I wanted to do since a few weeks.It enhances this work with fixes and behavior changes.It embeds#22435 and resolves issues like the one described in#20808.- makes ConsoleErrorEvent *not* extend the deprecated ConsoleExceptionEvent- replace ConsoleErrorEvent::markErrorAsHandled by ConsoleErrorEvent::setExitCode- triggers the deprecation in a more appropriate moment- renames ExceptionListener to ErrorListener- tweaks the behavior in relation to#22435Commits-------a7c67c9 [Console] Review console.ERROR related behavior
Uh oh!
There was an error while loading.Please reload this page.
This PR is a follow up of#18140 that I wanted to do since a few weeks.
It enhances this work with fixes and behavior changes.
It embeds#22435 and resolves issues like the one described in#20808.