Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] respect inline level when dumping objects as maps#22419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
goetas wants to merge3 commits intosymfony:3.2fromgoetas:pr-22392

Conversation

@goetas
Copy link
Contributor

@goetasgoetas commentedApr 13, 2017•
edited
Loading

QA
Branch?3.2
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#22409
LicenseMIT
Doc PR

Alternative version of#22409 that addresses the issues expressed in#22409 (comment)

@goetas
Copy link
ContributorAuthor

goetas commentedApr 13, 2017•
edited
Loading

  • The changes insrc/Symfony/Component/Yaml/Inline.php are:dumpArray has been split in two parts (dumpArray anddumpMap), anddumpMap is always used to dump objects when theDUMP_OBJECT_AS_MAP option is provided

  • The changes insrc/Symfony/Component/Yaml/Dumper.php are less "nice looking", but are mainly about detecting when theDUMP_OBJECT_AS_MAP case should be considered and making sure that theforeach loop does what is supposed to do. I'm open for suggestions to make it more "nice looking"...

@stofstof requested a review fromxabbuhApril 13, 2017 13:27
@xabbuh
Copy link
Member

I have no preference whether we merge this one or#22409. The changes to theDumper class made here look a bit overcomplicated to me. On the other hand I like the split of thedumpArray() method in theInline class.

@nicolas-grekasnicolas-grekas added this to the3.2 milestoneApr 13, 2017
@goetas
Copy link
ContributorAuthor

goetas commentedApr 13, 2017•
edited
Loading

I like the latest changes in#22409, closing if flavor of it.

@goetasgoetas closed thisApr 13, 2017
@goetasgoetas deleted the pr-22392 branchApril 25, 2017 11:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

4 participants

@goetas@xabbuh@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp