NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Fix getClientIp @return docblock#22418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:2.7frome-moe:ticket_22415

Apr 13, 2017

Merged

[HttpFoundation] Fix getClientIp @return docblock#22418

fabpot merged 1 commit intosymfony:2.7frome-moe:ticket_22415

Apr 13, 2017

Conversation

Copy link

Contributor

e-moe commentedApr 13, 2017

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#22415
License	MIT
Doc PR	none

carsonbot added Status: Needs Review HttpFoundation Bug labels

Apr 13, 2017

e-moe force-pushed theticket_22415 branch 2 times, most recently from9bfbb08 to6932072Compare

April 13, 2017 11:07

javiereguiluz approved these changes

Apr 13, 2017

View reviewed changes

Copy link

Member

javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

javiereguiluz added the Status: Reviewed label

Apr 13, 2017

e-moe force-pushed theticket_22415 branch 2 times, most recently from27556c9 to1fb44d3Compare

April 13, 2017 11:18

[HttpFoundation] Fix getClientIp@returndocblock

af3424f

e-moe force-pushed theticket_22415 branch from1fb44d3 toaf3424fCompare

April 13, 2017 11:19

xabbuh approved these changes

Apr 13, 2017

View reviewed changes

sstok approved these changes

Apr 13, 2017

View reviewed changes

nicolas-grekas added this to the2.7 milestone

Apr 13, 2017

Copy link

Member

fabpot commentedApr 13, 2017

Thank you@e-moe.

fabpot merged commitaf3424f intosymfony:2.7

Apr 13, 2017

fabpot added a commit that referenced this pull request

Apr 13, 2017

minor#22418[HttpFoundation] Fix getClientIp@returndocblock (e-moe)

5742958

This PR was merged into the 2.7 branch.Discussion----------[HttpFoundation] Fix getClientIp@return docblock| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#22415| License       | MIT| Doc PR        | noneCommits-------af3424f [HttpFoundation] Fix getClientIp@return docblock

Copy link

Contributor

ossinkine commentedJul 19, 2019

IMO the client IP can not be null in HTTP request. If you mock a request to use it in tests (as@miklcct described in#22415), you should make it correctly.
I suggest to revert this PR.

Copy link

Contributor

ossinkine commentedJul 19, 2019•
edited
Loading

Moreover, it is impossible even runtime: you'll get a noticeUndefined offset: 0 if$ipAddresses[0] is undefined.

ossinkine mentioned this pull request

Jul 23, 2019

[HttpFoundation] Revert getClientIp @return docblock#32682

Merged

fabpot added a commit that referenced this pull request

Aug 4, 2019

bug#32682[HttpFoundation] Revert getClientIp@returndocblock (ossi…

2b0f2de

…nkine)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Revert getClientIp@return docblock| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->This PR reverts#22418, see the comment#22418 (comment)Commits-------7568d34 [HttpFoundation] Revert getClientIp@return docblock

symfony-splitter pushed a commit to symfony/http-foundation that referenced this pull request

Aug 4, 2019

bug #32682 [HttpFoundation] Revert getClientIp@returndocblock (ossi…

6e2b0a9

…nkine)This PR was merged into the 3.4 branch.Discussion----------[HttpFoundation] Revert getClientIp@return docblock| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| License       | MIT<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch.-->This PR revertssymfony/symfony#22418, see the commentsymfony/symfony#22418 (comment)Commits-------7568d3452d [HttpFoundation] Revert getClientIp@return docblock