Please also add a test with an empty ArrayObject or stdClass, to ensure it keeps being dumped as{} and not[].

done

Hi, I'm not sure is the best approach to solve the issue.
The following test will fail:

// currently failspublicfunctiontestDumpingArrayObjectInstancesWithNumericKeysRespectsInlineLevel(){$deep =new \ArrayObject(array('d','e'));$inner =new \ArrayObject(array('b','c',$deep));$outer =new \ArrayObject(array('a',$inner));$yaml =$this->dumper->dump($outer,2,0, Yaml::DUMP_OBJECT_AS_MAP);$expected =<<<YAML0: a1:    0: b    1: c    2: { 0: d, 1: e }YAML;$this->assertEquals($expected,$yaml);}// This works with 3.1 branchpublicfunctiontestDumpingArrayObjectInstancesWithNumericKeysInlined(){$deep =new \ArrayObject(array('d','e'));$inner =new \ArrayObject(array('b','c',$deep));$outer =new \ArrayObject(array('a',$inner));$yaml =$this->dumper->dump($outer,0,0, Yaml::DUMP_OBJECT_AS_MAP);$expected =<<<YAML{ 0: a, 1: { 0: b, 1: c, 2: { 0: d, 1: e } } }YAML;$this->assertEquals($expected,$yaml);}

and the strategy (casting array object ot array) will make really hard (if not impossible) to solve this case

and with the current strategy,https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Yaml/Inline.php#L176 is never reached sincecastObjectToArray removes all theArrarObject instances

I will also try to find a solution

Status: Needs work

Here is my version of the fix#22419

Question: why#21471 is considered as a new feature? IMO should be a bugfix and included in the 3.2 branch.
Empty arrays should be serialized as[ ], and empty arrayobject instances should be serialized as{ }. The same behavior is used withjson_encode.

The only feature in#21471 should bethis that allows to dump an empty arrayobject (or a stdclass) as[ ] instead of{ }

Question: why#21471 is considered as a new feature?

This relies on adding a new constant for the configuration flag => this is a new feature for the component

@xabbuh did you check my work at#22419

@stof i see, thanks

@xabbuh if this is the candidate PR to be merged, do you mind adding:

publicfunctiontestDumpingArrayObjectInstancesWithNumericKeysRespectsInlineLevel()    {$deep =new \ArrayObject(array('d','e'));$inner =new \ArrayObject(array('b','c',$deep));$outer =new \ArrayObject(array('a',$inner));$yaml =$this->dumper->dump($outer,2,0, Yaml::DUMP_OBJECT_AS_MAP);$expected =<<<YAML0: a1:    0: b    1: c    2: { 0: d, 1: e }YAML;$this->assertEquals($expected,$yaml);    }

?

Did not knowstdClass can be used in aforeach loop. Looks to be "iterable" even ifis_iterable says is nothttps://3v4l.org/bY9IC

@goetas it does not pass theiterable typehint either. but iterating over a non-iterable object iterates over public properties in PHP.

@stof Is so beautiful to learn things about PHP every day after so many years☺️

Seehttps://3v4l.org/tu1Z0 for the proof btw

Do this PR need still work?

For me is 👍

Thank you@xabbuh.