Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Allow terminal dimensions to be set to 0 (unbounded)#22377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b8d968f to469cff2CompareMember
stof commentedApr 11, 2017
@nicolas-grekas are we sure that the existing code treats 0 as unbounded though ? |
ContributorAuthor
duncan3dc commentedApr 11, 2017
Forformatting exceptions it does, although not technically "unbounded" I guess ( |
Member
stof commentedApr 11, 2017
@duncan3dc yeah, fine enough 😄 |
469cff2 to4c1b001CompareMember
fabpot commentedApr 11, 2017
Thank you@duncan3dc. |
fabpot added a commit that referenced this pull requestApr 11, 2017
…ded) (duncan3dc)This PR was merged into the 3.2 branch.Discussion----------[Console] Allow terminal dimensions to be set to 0 (unbounded)| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21513| License | MITA previous PR (#20328) changed the behavior of terminals with undefined widths from unbounded to 80 characters. And due to the way the existing code worked it become impossible to set a terminal to be unbounded again. This PR provides a way to restore the previous behavior:```phpputenv('COLUMNS=0');```Commits-------4c1b001 Allow terminal dimensions to be set to 0 (unbounded)
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR (#20328) changed the behavior of terminals with undefined widths from unbounded to 80 characters. And due to the way the existing code worked it become impossible to set a terminal to be unbounded again. This PR provides a way to restore the previous behavior: