Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpKernel] Add glob support for bundle resource locator#22350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
pierredup wants to merge1 commit intosymfony:masterfrompierredup:glob-bundles

Conversation

@pierredup
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsN/A
LicenseMIT
Doc PRN/A

This is a continuation of#21270 and#21635 to add glob support when locating bundle resources.
So the following becomes possible:

@SomeBundle/{Action,Controller}@SomeBunde/Resources/config/*.yml

sstok, Nek-, and apfelbox reacted with hooray emoji
@fabpot
Copy link
Member

I don't understand the use case as it always returns the first matching resource.

@pierredup
Copy link
ContributorAuthor

The default behaviour is to return the first match , but if you pass the third parameter tolocateResource asfalse, then it returns an array of matching resources

@nicolas-grekas
Copy link
Member

Closing as there is no activity, and I'm not sure this works in practice, as the glob will miss overridden resources. Feel free to reopen of course.

@pierredup
Copy link
ContributorAuthor

Would the overridden resource not already be resolved at this point?

@stof
Copy link
Member

nope. The bundle inheritance is gone, but this locator still allows project-level overriding.

@pierredup
Copy link
ContributorAuthor

But by the time it does thefile_exists check, should it not aleady have resolved the overridden resource, to know which file and path to check?

@stof
Copy link
Member

but for a glob, each one of the match could be overridden independently (and this PR won't handle it).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@pierredup@fabpot@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp