Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix second auto-registration#22311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
weaverryan commentedApr 6, 2017
This break was caused by#22254.@nicolas-grekas That PR strikes me itself as a BC break. This PR fixes the linked issue#22309... are there any other behavior changes due to#22254? And if so (and if we're ok with those minor breaks, because it was a bug), is the user seeing a very clear error when they upgrade? I'm uncomfortable with behavior changes in patch releases (but also realize it's trick with bugs) |
nicolas-grekas commentedApr 6, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
#22254 fixes a bug, that hits people hard and in unexpected ways. For some, it looked like it worked, for others, it just didn't work. The discussion is in the PR. Every bug fix is a BC break. We couldn't live with this one a "bug-as-a-feature". This PR is fixes a "return" that I inadvertently added in the code (for a behavior that missed a test case). |
fabpot commentedApr 6, 2017
Thank you@nicolas-grekas. |
This PR was merged into the 2.8 branch.Discussion----------[DI] Fix second auto-registration| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22309| License | MIT| Doc PR | -My badCommits-------c02de84 [DI] Fix second auto-registration
My bad