Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Moved $this->setDate() before the deprecation handling.#22304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@mpdonadio
Copy link
Contributor

@mpdonadiompdonadio commentedApr 6, 2017
edited
Loading

QA
Branch?3.2
Bug fix?yes
New feature?no
BC breaks?no?
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

#22036 merged the patch into the wrong place; the$this->setDate() happens after the deprecation handling, so it does not always get called.

See alsohttps://www.drupal.org/node/2712647?page=1#comment-12025349

@nicolas-grekasnicolas-grekas added this to the3.2 milestoneApr 7, 2017
@nicolas-grekas
Copy link
Member

Thank you@mpdonadio.

nicolas-grekas added a commit that referenced this pull requestApr 7, 2017
…pdonadio)This PR was squashed before being merged into the 3.2 branch (closes#22304).Discussion----------Moved $this->setDate() before the deprecation handling.| Q             | A| ------------- | ---| Branch?       | 3.2 <!-- see comment below -->| Bug fix?      | yes| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->| BC breaks?    | no?| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->| Tests pass?   | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features--><!--- Bug fixes must be submitted against the lowest branch where they apply  (lowest branches are regularly merged to upper ones so they get the fixes too).- Features and deprecations must be submitted against the master branch.- Please fill in this template according to the PR you're about to submit.- Replace this comment by a description of what your PR is solving.-->#22036 merged the patch into the wrong place; the `$this->setDate()` happens after the deprecation handling, so it does not always get called.See alsohttps://www.drupal.org/node/2712647?page=1#comment-12025349Commits-------b6df4e7 Moved ->setDate() before the deprecation handling.
@mpdonadiompdonadio deleted the set-date-wrong-place branchApril 8, 2017 01:43
@fabpotfabpot mentioned this pull requestMay 1, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mpdonadio@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp