Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Rework config hierarchy: defaults > instanceof > service config#22294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes from1 commit
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
8698228 Reworking the instanceof feature to act more like a "default" than li…
weaverryandb96c89 Moving changes tracking from ChildDefinition to Definition and fixing…
weaverryan24a6a83 Adding a test for the config overriding order
weaverryan6202909 Fixing a bug where instanceof was not copied into the new Definition …
weaverryan28d7d8d Adding a test for instanceof behavior with parent-child services
weaverryande0f718 Adding more tests
weaverryan8fd3738 Updating calls logic to merge/override with instanceof
weaverryan5e39c5d Using Definition instead of ChildDefinition for instanceofConditionals
weaverryan132201e Fixing outdated type-hint
weaverryand7c4836 Fixing method name after rebase
weaverryana44d92b Making instanceof method call matching case insensitive
weaverryana2aea3b Fixing an edge case with instanceof property overriding when value is…
weaverryan5f9ca7c A few tweaks thanks to nicolas
weaverryan2021675 Fixing missing use
weaverryana95de6c Thanks fabbot!
weaverryan34ad21a Updating more code for ChildDefinition -> Definition change
weaverryan371fec2 Fixing failing tests: some of the compiler passes caused false "chang…
weaverryan82fa3c0 Updating DI tags logic to merge, but not replace tags
weaverryan1f2ce11 thanks fabbot!
weaverryanFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Fixing method name after rebase
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd7c48368a19da0920d15c6145f5db1729ce7de4f
There are no files selected for viewing
2 changes: 1 addition & 1 deletionsrc/Symfony/Component/DependencyInjection/Compiler/ResolveDefinitionInheritancePass.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.