Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI/Yaml] Remove@experimental flag from "instanceof" and "prototype"#22286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Yaml/Yaml.php Outdated
| /** | ||
| * @experimental in version 3.3 | ||
| */ | ||
| constPARSE_CUSTOM_TAGS =512; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think I would then move this flag betweenPARSE_CONSTANT andDUMP_EMPTY_ARRAY_AS_SEQUENCE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
moved up in the list
weaverryan commentedApr 5, 2017
I also think we need to commit to these features and follow normal deprecation policies. 👍 |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedApr 5, 2017
Thank you@nicolas-grekas. |
…" and "prototype" (nicolas-grekas)This PR was merged into the 3.3-dev branch.Discussion----------[DI/Yaml] Remove `@experimental` flag from "instanceof" and "prototype"| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -We don't need this flag on these features: the implementation is stable, and regular deprecations should be the way to go in the event where we decide to remove this later on.That would leave only one single `@experimental` feature in 3.3: `CacheItem::getPreviousTags()`, which looks legitimate to me (since this method is aiming at interop).Commits-------e8723df [DI/Yaml] Remove `@experimental` flag from "instanceof" and "prototype"
Uh oh!
There was an error while loading.Please reload this page.
We don't need this flag on these features: the implementation is stable, and regular deprecations should be the way to go in the event where we decide to remove this later on.
That would leave only one single
@experimentalfeature in 3.3:CacheItem::getPreviousTags(), which looks legitimate to me (since this method is aiming at interop).