Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix HttpCache test#22224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromchalasr:skip-httpcache-win
Apr 3, 2017
Merged

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedMar 30, 2017•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?no
Fixed tickets#22043 (comment)
LicenseMIT
Doc PRn/a

will make appveyor green.

@chalasr
Copy link
MemberAuthor

The refactoring made in#22043 is not the cause, reverting it makes this test keep failing on windows.

@marek-pietrzak-tg
Copy link
Contributor

Wouldn't be better to fix the error on Windows or create alternative test which won't break there, instead of skipping the test?

@chalasrchalasr changed the titleSkip breaking test on windowsFix HttpCache testMar 30, 2017
@chalasrchalasrforce-pushed theskip-httpcache-win branch 2 times, most recently from8af132e to6d66cedCompareMarch 30, 2017 20:12
@chalasr
Copy link
MemberAuthor

Status: needs work

@chalasr
Copy link
MemberAuthor

Spent some hours at trying to debug it and I can't find the bottleneck, so keep skipping on windows as it runs fine on other platforms.

@chalasr
Copy link
MemberAuthor

Status: needs review

@fabpot
Copy link
Member

Thank you@chalasr.

@fabpotfabpot merged commit3178f50 intosymfony:masterApr 3, 2017
fabpot added a commit that referenced this pull requestApr 3, 2017
This PR was merged into the 3.3-dev branch.Discussion----------Fix HttpCache test| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | no| Fixed tickets |#22043 (comment)| License       | MIT| Doc PR        | n/awill make appveyor green.Commits-------3178f50 Fix failing HttpCache test on windows
@chalasrchalasr deleted the skip-httpcache-win branchApril 3, 2017 23:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chalasr@marek-pietrzak-tg@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp