Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Restore SessionListener class for backward compatibility with Silex#22171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
GromNaN wants to merge2 commits intosymfony:masterfromGromNaN:session-listener

Conversation

@GromNaN
Copy link
Member

@GromNaNGromNaN commentedMar 26, 2017•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketssilexphp/Silex#1496
LicenseMIT
Doc PRN/A

The PR#21625 renamed the classes fromSymfony\Component\HttpKernel\EventListener :

  • ...\SessionListener to...\AbstractSessionListener
  • ...\TestSessionListener to...\AbstractTestSessionListener

This isbreaking the Silex class that extends it.

To keep the backward compatibility, abstract classes are renamed to their original names and subclasses using container injection are prefixed byContainerAware.

Also added some tests.

SessionListener and TestSessionListener are extended outside of Symfonyin Silex. These classes cannot be renamed.
@nicolas-grekas
Copy link
Member

Looking at the failure, the core issue is:
PHP Fatal error: Interface 'Symfony\Component\DependencyInjection\ServiceSubscriberInterface' not found

@nicolas-grekasnicolas-grekas added this to the3.3 milestoneMar 28, 2017
@nicolas-grekas
Copy link
Member

I'm going to take over this one. To me, we just need to removeServiceSubscriberInterface from the interfaces implemented bySessionListener andTestSessionListener.

@GromNaN
Copy link
MemberAuthor

GromNaN commentedMar 28, 2017•
edited
Loading

Removing theServiceSubscriberInterface solves the issue of having a hard dependency to the DI component. But ...

fabpot added a commit that referenced this pull requestMar 31, 2017
…*SessionListener (nicolas-grekas)This PR was merged into the 3.3-dev branch.Discussion----------[HttpKernel] Dont implement ServiceSubscriberInterface on *SessionListener| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#22171,silexphp/Silex#1496| License       | MIT| Doc PR        | -Implementing `ServiceSubscriberInterface` creates a dep on the DI component, which Silex can't afford. Let's revert that part.@GromNaN can you please confirm this fixes your issue?Commits-------7cd90f5 [HttpKernel] Dont implement ServiceSubscriberInterface on *SessionListener
@fabpotfabpot closed thisMar 31, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@GromNaN@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp