Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fixed fatal error when the command is not defined#22144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
lyrixx commentedMar 24, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | https://github.com/symfony/symfony/pull/18140/files#r107871406 |
| License | MIT |
| Doc PR |
Member
fabpot commentedMar 24, 2017
@lyrixx Can you add a tests to avoid regressions? |
Member
wouterj commentedMar 25, 2017
I think we should also trigger this event when CommandNotFound exceptions are thrown. What about allowing |
Member
chalasr commentedMar 25, 2017
+1 for having the event fired on command not found. As there is currently no working case where the command is null I think it's safe to make it nullable in this specific event. |
Member
fabpot commentedMar 25, 2017
Thank you@lyrixx. |
fabpot added a commit that referenced this pull requestMar 25, 2017
…d (lyrixx)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Fixed fatal error when the command is not defined| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |https://github.com/symfony/symfony/pull/18140/files#r107871406| License | MIT| Doc PR |Commits-------d5b41b6 [Console] Fixed fatal error when the command is not defined
fabpot added a commit that referenced this pull requestApr 5, 2017
…lasr)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Allow to catch CommandNotFoundException| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22144 (comment)| License | MIT| Doc PR | n/aBasically reverts#22144, making the command argument optional in console.error event instead, so that `CommandNotFoundException` can be handled as any other console error.Commits-------b21ce85 [Console] Allow to catch CommandNotFoundException
symfony-splitter pushed a commit to symfony/console that referenced this pull requestApr 5, 2017
…lasr)This PR was merged into the 3.3-dev branch.Discussion----------[Console] Allow to catch CommandNotFoundException| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony/symfony#22144 (comment)| License | MIT| Doc PR | n/aBasically reverts #22144, making the command argument optional in console.error event instead, so that `CommandNotFoundException` can be handled as any other console error.Commits-------b21ce850e7 [Console] Allow to catch CommandNotFoundException
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.