Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Fix error handling on ini file parsing#22105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
xabbuh approved these changesMar 22, 2017
Member
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Member
javiereguiluz commentedMar 22, 2017
👍 |
Member
xabbuh commentedMar 22, 2017
Thank you@chalasr. |
xabbuh added a commit that referenced this pull requestMar 22, 2017
This PR was merged into the 3.3-dev branch.Discussion----------[Yaml] Fix error handling on ini file parsing| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/aShould make travis green again on master./cc@xabbuhCommits-------71cec82 [Yaml] Fix error handling in parser
Contributor
GuilhemN commentedMar 22, 2017
This part of the code supports things that shouldn't be. "foo"bar is not valid. bar"foo" is valid but should be parsed as This could be fixed by updating some things:
foreach ($linesas$line) {if ($this->preg_match('/[ \t]+#/',$line,$match,PREG_OFFSET_CAPTURE)) {$line =substr($line,0,$match[0][1]); }if ('' ===trim($line)) {$value .="\n";$previousLineWasNewline =true; }elseif ($previousLineWasNewline) {$value .=trim($line);$previousLineWasNewline =false; }else {$value .=''.trim($line);$previousLineWasNewline =false; }} |
fabpot added a commit that referenced this pull requestMay 24, 2017
This PR was merged into the 3.3 branch.Discussion----------[Yaml] fix multiline block handling| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21114,#22105 (comment)| License | MIT| Doc PR |Commits-------a2079d6 [Yaml] fix multiline block handling
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should make travis green again on master.
/cc@xabbuh