Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] deprecate "? " starting unquoted strings#22059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMar 19, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #20579 |
| License | MIT |
| Doc PR |
UPGRADE-3.3.md Outdated
| * Deprecated support for implicitly parsing non-string mapping keys as strings. Mapping keys that are no strings will | ||
| lead to a`ParseException` in Symfony 4.0. Use the`PARSE_KEYS_AS_STRINGS` flag to opt-in for keys to be parsed as | ||
| * starting an unquoted string with a question mark followed by a space is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
starting ... ->Starting ... in all UPGRADE files.
UPGRADE-4.0.md Outdated
| * Removed support for implicitly parsing non-string mapping keys as strings. Mapping keys that are no strings will | ||
| result in a`ParseException`. Use the`PARSE_KEYS_AS_STRINGS` flag to opt-in for keys to be parsed as strings. | ||
| * starting an unquoted string with a question mark followed by a space is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is throws ->throws
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
286253c to731a74eCompare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedMar 20, 2017
Thank you@xabbuh. |
This PR was merged into the 3.3-dev branch.Discussion----------[Yaml] deprecate "? " starting unquoted strings| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets |#20579| License | MIT| Doc PR |Commits-------731a74e [Yaml] deprecate "? " starting unquoted strings