Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Skip abstract definitions in compiler passes#22039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
chalasr commentedMar 17, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21761 |
| License | MIT |
| Doc PR | n/a |
Member
xabbuh commentedMar 17, 2017
👍 Status: Reviewed |
nicolas-grekas approved these changesMar 17, 2017
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
GuilhemN approved these changesMar 17, 2017
Contributor
GuilhemN left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
| $container->setDefinition('a',$abstractDefinition); | ||
| $this->process($container); | ||
| $this->assertSame(array(),$container->getDefinition('doctrine.dbal.default_connection.event_manager')->getMethodCalls()); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
assertEmpty()?
Member
fabpot commentedMar 17, 2017
Thank you@chalasr. |
fabpot added a commit that referenced this pull requestMar 17, 2017
This PR was merged into the 3.3-dev branch.Discussion----------Skip abstract definitions in compiler passes| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21761| License | MIT| Doc PR | n/aCommits-------fc1ba0d Skip abstract definitions in compiler passes
nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull requestApr 13, 2017
fabpot added a commit that referenced this pull requestApr 13, 2017
…las-grekas)This PR was squashed before being merged into the 3.3-dev branch (closes#22420).Discussion----------[DI] Make tagged abstract services throw earlier| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -As spotted by@stof in#22388 (comment), skipping abstract tagged services removes an opportunity to report config mistakes to users.Instead of skipping them, let's throw as done before (thus reverting#22039, ping@chalasr).I made `$container->findTaggedServiceIds()` accept a 2nd arg to make this more systematic.To keep the possibility to have abstract tagged services *for the purpose of tag inheritance*, `ResolveTagsInheritancePass` now resets their tags.Commits-------388e4b3 [DI] Make tagged abstract services throw earliercd06c12 Revert "minor#22039 Skip abstract definitions in compiler passes (chalasr)"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.