For reference, here are the original decisions we made about how to try to autowire setter methods, but not fail as often / consistently when compared with constructor autowiring - items 2, 3 and 4 in my comment:#17608 (comment)

I think this PR is wonderful! The@required completely removes the need for us to try to make this decision for the user.

@nicolas-grekas the only thing I noticed when trying this was that if I had@required above a method withzero arguments, that method wasn't called. With this philosophy, it nowfeels like this method should also be called. However, if I have a method with a single optional argument that cannot be autowired, itfeels like that one shouldnot be called (which is how it works now). But those are kind of the same situation (i.e. should we call a method when we have nothing to pass to it), so I'm not totally sure :).

Thanks!

@weaverryan As@required is added by the user, he knows what he wants. So to me, the methods marked with@required must always be called, regardless of their arguments.

Nicolas and I were talking off-GitHub, and we agree - we should always call methods with@required, unless they cannot be called due to non-autowireable args (then we should throw an exception).

What I forgot was that a method withno arguments isgetter-injected. In other words, it's incorrect for me to assume that I could add@required above a method with no args (e.g.configure()) and expect it to be called. This is a little magic - that we're deciding between setter and getter injection based on the presence/absence of at least one arg -, but it seems like it needs to be done that way (and Nicolas and I discussed how we should perhaps throw an exception if there is an@required method with no args, but also not return type - so at least the user will get a clear error).

I think throwing an exception when there is a@required annotation without arguments is a good idea indeed.

Exceptions added, all code related to skipping logic removed.
I also reverted#21602: abstract getter don't need to be autowired anymore, we'd better encourage using the annotation instead.

minor comment, 👍