Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Serializer] Add option to register a circular_reference_handler#22011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromlyrixx:serializer-circular-reference-handlerMar 22, 2017
Merged
[FrameworkBundle][Serializer] Add option to register a circular_reference_handler#22011
fabpot merged 1 commit intosymfony:masterfromlyrixx:serializer-circular-reference-handlerMar 22, 2017
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cbdc24d to0a638f5CompareNek- added a commit to Nek-/symfony-docs that referenced this pull requestMar 15, 2017
This is added bysymfony/symfony#22011This commit also fix missing serializer related missing options in the yamlconfig example.
nicolas-grekas approved these changesMar 17, 2017
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
dunglas approved these changesMar 21, 2017
Member
dunglas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 great new feature! But can you add a test?
Member
fabpot commentedMar 22, 2017
Thank you@lyrixx. |
fabpot added a commit that referenced this pull requestMar 22, 2017
… circular_reference_handler (lyrixx)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle][Serializer] Add option to register a circular_reference_handler| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | ----Right now, it's quite hard (especially for new comers) to register a CircularReferenceHandler:---This PR introduce an option to wire a service to the internal Object Normalizer.Commits-------0a638f5 [FrameworkBundle][Serializer] Add option to register a "circular_reference_handler"
xabbuh added a commit to symfony/symfony-docs that referenced this pull requestApr 15, 2017
…option to reference: circular_reference_handler (Nek-)This PR was merged into the master branch.Discussion----------[FrameworkBundle][Serializer] Add new framework bundle option to reference: circular_reference_handlerThis PR provides documentation for this other PRsymfony/symfony#22011It should not be merged before the related Symfony PR is merged.It also fixes missing options in the example YAML config file.Commits-------964c31e Add new framework bundle option to reference: circular_reference_handler
Merged
fabpot added a commit that referenced this pull requestFeb 19, 2018
…rence_handler (dunglas)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle] Add missing XML config for circular_reference_handler| Q | A| ------------- | ---| Branch? | 3.3| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR | n/a* Add missing XML config for circular_reference_handler (#22011)* Add testsCommits-------611ff59 [FrameworkBundle] Add missing XML config for circular_reference_handler. Add tests.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, it's quite hard (especially for new comers) to register a CircularReferenceHandler:
This PR introduce an option to wire a service to the internal Object Normalizer.