Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][TwigBundle] Require PSR-11 container instead of Symfony container#21979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| usePsr\Container\ContainerInterface; | ||
| usePsr\Log\LoggerInterface; | ||
| useSymfony\Component\DependencyInjection\ContainerInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not possible here because would break with ContainerAwareInterface
| useSymfony\Component\HttpKernel\CacheWarmer\WarmableInterface; | ||
| useSymfony\Component\Translation\TranslatorasBaseTranslator; | ||
| useSymfony\Component\Translation\MessageSelector; | ||
| useSymfony\Component\DependencyInjection\ContainerInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not possible because would break with getParameter
enumag commentedMar 14, 2017
@nicolas-grekas Fixed, thanks! |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedMar 14, 2017
Thank you@enumag. |
… instead of Symfony container (enumag)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle][TwigBundle] Require PSR-11 container instead of Symfony container| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |As discussed in#21978 here is the second PR.Commits-------857ce7c [FrameworkBundle][TwigBundle] Require PSR-11 container instead of Symfony container
As discussed in#21978 here is the second PR.