Hello,
When I apply the code to my Symfony 3.2.5 app, I get this message

PHP Fatal error:  Declaration of Symfony\Component\Console\Event\InputDecorator::hasParameterOption($values) must be compatible with Symfony\Component\Console\Input\InputInterface::hasParameterOption($values, $onlyParams = false) in /app/www/vendor/symfony/symfony/src/Symfony/Component/Console/Event/ConsoleCommandEvent.php on line 70

I use PHP 7.1.

I tested it for this issue#21841 (comment)

By the way, I don't get why you set a final class in the console event file? Why don't you create a dedicated file for this class?

@pierre-tranchard The signature ofInputInterface::hasParameterOption() has changed in 3.0. Given this patch targets 2.8 and you're testing on 3.2, it's normal you get this error.
Here is the patch for 3.2:3.2...chalasr:console-event-32 in case you can try it instead (which would be great), thank you anyway.

Why don't you create a dedicated file for this class?

That's because we only need this class for this event, nobody should use it directly, nor other place in the core (like this you don't get this file listed in your IDE). Others may think differently but IMHO it's not worth having a dedicated file for this class.

@chalasr after a new test based on the modification, i still don't get the arguments and options

Well, the patch comes with a test case proving that arguments/options added to the definition through the event are properly considered when running the command. Did you removed the manual binding added to workaround the BC break?
The best would be to provide an simple script reproducing your use case like the one provided by@bendavies in#21841 (comment).

Yes I removed the manual binding.

here's my delegated input class but I can't disclosed more details

class DelegatedInput extends ArrayInput{    /**     * DelegatedInput constructor.     *     * @param InputInterface  $source     * @param InputDefinition $definition     * @param array           $ignoredAttrs     * @param array           $ignoredOpts     */    public function __construct(        InputInterface $source,        InputDefinition $definition,        $ignoredAttrs = [],        $ignoredOpts = []    ) {        $source->bind($definition);        $this->definition = $definition;        foreach ($source->getArguments() as $name => $value) {            if (!in_array($name, $ignoredAttrs)) {                $this->setArgument($name, $value);            }        }        foreach ($source->getOptions() as $name => $value) {            if (!in_array($name, $ignoredOpts)) {                $this->setOption($name, $value);            }        }        parent::__construct([]);    }    /**     * @return string     */    public function __toString()    {        $pattern = implode(' ', $this->getArguments());        if (!empty($pattern)) {            $pattern = sprintf(" %s", $pattern);        }        foreach ($this->getOptions() as $option => $value) {            if (is_string($value)) {                $pattern .= sprintf(" --%s=%s", $option, $value);            } elseif (is_bool($value) && $value) {                $pattern .= sprintf(" --%s", $option);            }        }        return $pattern;    }}

When my supervisor command calls the supervised command, a delegated input instance is created and passed to the supervised command.
If i remove the bind instruction, I don't have the options and arguments from the supervisor command (except the command argument)

I'm going to write a script reproducing your use case using the custom input you given.

@pierre-tranchard I'm able to reproduce your issue:https://github.com/chalasr/console-bcbreak
I'm on it.

edit: I'm not, I can't make it work with 3.2.4 (before BC break).

ok

Could you help to make it work on 3.2.4? I surely not reproduce your use case correctly.

my fix didn't work in all case either.
I'll try to find you a case so that you can reproduce the fail

to fix my bug, I had to remove the bind instruction from my delegated input class and I had to set the input bound to false in my supervisor base class run method.

@pierre-tranchard I have no idea of what your code looks like but anyway, if your original code is still broken after this patch, I think the first fix should be reverted from maintenance branches and re-discussed on master, including this.

Last chance before doing so, could you please try3.2...chalasr:console-event-32 on your original code? I updated it and this to mark the input as bound only if arguments/options values are set from the command event, it should be ok.

ping@pierre-tranchard@bendavies
It would be nice to act on this for the next patch releases. Thank you.

I'll have a look on it.

@chalasr sorry but it still doesn't work for me.

I got to do the following in my base supervisor class

    /**     * @inheritdoc     */    public function run(InputInterface $input, OutputInterface $output)    {       // several things        $this->setInputBound(false);        parent::run($input, $output);    }

I've merged the PR that reverts the fix in the meantime.

Thanks, I will repropose the whole on master.