Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger#21933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if ($workflow['supports']) { | ||
| foreach ($workflow['supports']as$supportedClassName) { | ||
| $strategyDefinition =newDefinition(ClassInstanceSupportStrategy::class,array($supportedClassName)); | ||
| $strategyDefinition =newDefinition(Workflow\SupportStrategy\ClassInstanceSupportStrategy::class,array($supportedClassName)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To reduce the number ofuse statement and to be consistant with other "...\Workflow" usage.
| // Enable the AuditTrail | ||
| if ($workflow['audit_trail']['enabled']) { | ||
| $listener =newDefinition(Workflow\EventListener\AuditTrailListener::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
use ause statement instead? more "SF style" to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Right now, there are more usage of "this style" than FQCN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just saw that, in the Workflow namespace in fact. OK then.
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
… the AuditTrail Logger (lyrixx)This PR was squashed before being merged into the 3.3-dev branch (closessymfony#21933).Discussion----------[FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | ----This will increase the visibility of the Listener. We could encourage people to use at least `%kernel.debug%` value.---Note for the merge: There are two commits, this is done on purpose (2 different things, but easier to do only one PR)Commits-------633c039 [Workflow] Added the workflow name in log generated by AuditTrailListenerb786bcc [FrameworkBundle][Workflow] Add a way to enable the AuditTrail Logger
This PR was merged into the 3.3-dev branch.Discussion----------[Workflow] sync the changelog| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#20751,#21334,#21933,#21935,#21950| License | MIT| Doc PR |Commits-------98a18ee [Workflow] sync the changelog
Uh oh!
There was an error while loading.Please reload this page.
This will increase the visibility of the Listener. We could encourage people to use at least
%kernel.debug%value.Note for the merge: There are two commits, this is done on purpose (2 different things, but easier to do only one PR)