Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix autoloader in insulated clients#21922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| $path =str_replace("'","\\'",$r->getFileName()); | ||
| $requires .="require_once '".str_replace("'","\\'",(new \ReflectionObject($this->kernel))->getFileName())."';\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wouldn'tvar_export be better than doing manual escaping ? Thus, the escaping is incomplete in case there is a\ just before a quote
nicolas-grekasMar 8, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Dunno :) Currently, this is consistent with other places (HttpKernel's Client) and with the previous code. I don't see the need to diverge here (in this PR).
This PR was merged into the 2.7 branch.Discussion----------[travis] Test with hhvm 3.18| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21900| License | MIT| Doc PR | -Needs#21922 on master to be green also.Works aroundfacebook/hhvm#7722.Commits-------7f1f0cb [travis] Test with hhvm 3.18
fabpot commentedMar 8, 2017
Thank you@nicolas-grekas. |
…olas-grekas)This PR was merged into the 3.3-dev branch.Discussion----------[FrameworkBundle] Fix autoloader in insulated clients| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Related to the deprecation of the class loader component:the `Client` already uses this code in `HttpKernel`, but `FrameworkBundle` is missing the same update.Spotted while debugging the hhvm 3.18 issue (the chain is: `ComposerResource` sees different vendors, thus says the kernel cache is not fresh, thus it is rebuild, thus we hitfacebook/hhvm#7722).Commits-------414ac5d [FrameworkBundle] Fix autoloader in insulated clients
Uh oh!
There was an error while loading.Please reload this page.
Related to the deprecation of the class loader component:
the
Clientalready uses this code inHttpKernel, butFrameworkBundleis missing the same update.Spotted while debugging the hhvm 3.18 issue (the chain is:
ComposerResourcesees different vendors, thus says the kernel cache is not fresh, thus it is rebuild, thus we hitfacebook/hhvm#7722).