Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PHPunitBridge] Count @expectedDeprecation as an assertion#21896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMar 6, 2017
fabpot commentedMar 6, 2017
@xabbuh This can be closed then, right? |
xabbuh commentedMar 6, 2017
wouterj commentedMar 6, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, except that#21828 is merged as a feature. However, I consider it a bug fix and thus it has to be backported to 3.2. Imo, counting the |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 for 3.2 then
xabbuh commentedMar 6, 2017
Fair enough, but note that you will probably check first that the test is neither skipped nor incomplete (see how#21828 was implemented). |
wouterj commentedMar 6, 2017
Yeah, I think if it's decided to backport this to 3.2, the#21828 PR should simply be backported (and this PR should just be closed). |
fabpot commentedMar 6, 2017
Except the trait does not exist in 3.2 IIRC, so this should be done here. |
wouterj commentedMar 6, 2017
Ah, my bad. Updated the PR to match the code added in 3.3. |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
fabpot commentedMar 6, 2017
Thank you@wouterj. |
… (wouterj)This PR was merged into the 3.2 branch.Discussion----------[PHPunitBridge] Count @expectedDeprecation as an assertion| Q | A| ------------- | ---| Branch? | 3.2| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -By adding `addToAssertionCount()`, the `@expectedDeprecation` annotation is recognized as an assertion by PHPUnit. This means PHPUnit will not report the test as risky because it does not contain any assertion.Commits-------ba5c0f4 Count @expectedDeprecation as an assertion
By adding
addToAssertionCount(), the@expectedDeprecationannotation is recognized as an assertion by PHPUnit. This means PHPUnit will not report the test as risky because it does not contain any assertion.