Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rename TimeZoneTransformer into TimezoneTransformer#21875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lepiaf wants to merge1 commit intosymfony:3.2fromlepiaf:rename-timezone-transformer
Closed

Rename TimeZoneTransformer into TimezoneTransformer#21875

lepiaf wants to merge1 commit intosymfony:3.2fromlepiaf:rename-timezone-transformer

Conversation

@lepiaf
Copy link
Contributor

@lepiaflepiaf commentedMar 5, 2017•
edited
Loading

QA
Branch?3.2
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#11028
LicenseMIT
Doc PRno

HeahDude and Nek- reacted with hooray emoji
@javiereguiluz
Copy link
Member

@lepiaf thanks for contributing a fix for this super old issue report.

To give some context:

  1. Symfony usesTimezone sometimes andTimeZone others.
  2. PHP uses "TimeZone" in its classes:http://php.net/manual/en/class.intltimezone.php
  3. In UK English, "timezone" doesn't exist (it's "time zone") but in US English, it's more common to use "timezone", so the camelized version should be "Timezone".

Symfony always favors US English, so this change looks correct to me!

Intl
----

* Rename`TimeZoneTransformer` class into`TimezoneTransformer`
Copy link
Member

@nicolas-grekasnicolas-grekasMar 6, 2017•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

since the class is internal (since 2.8), I'd suggest removing these, and apply this PR on 3.2

xabbuh reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@nicolas-grekasnicolas-grekas added this to the3.2 milestoneMar 6, 2017
@lepiaflepiaf changed the base branch frommaster to3.2March 6, 2017 20:28
Intl
----

* Rename`TimeZoneTransformer` class into`TimezoneTransformer`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

internal class, not needed

3.2.5
-----

* Rename`TimeZoneTransformer` class into`TimezoneTransformer`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

internal class, not needed

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@Tobion
Copy link
Contributor

👍

@fabpot
Copy link
Member

Good catch, thanks@lepiaf.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

7 participants

@lepiaf@javiereguiluz@Tobion@fabpot@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp