I've added indexes to the new time column for MySQL, SQLite, and PgSQL, but I'm not sure how to do so with theoci orsqlsrv drivers. Here are the "create table" statements I have updated so far:

MySQL

$sql ="CREATE TABLE$this->table ($this->idCol VARBINARY(128) NOT NULL PRIMARY KEY,$this->dataCol BLOB NOT NULL,$this->timeCol INTEGER UNSIGNED NOT NULL, KEY{$this->table}_{$this->timeCol}_idx ($this->timeCol)) COLLATE utf8_bin, ENGINE = InnoDB";

CREATETABLE `sessions` (`sess_id` varbinary(128)NOT NULL,`sess_data` blobNOT NULL,`sess_time`int(10) unsignedNOT NULL,PRIMARY KEY (`sess_id`), KEY`sessions_sess_time_idx` (`sess_time`)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin

SQLite

$sql ="BEGIN; CREATE TABLE$this->table ($this->idCol TEXT NOT NULL PRIMARY KEY,$this->dataCol BLOB NOT NULL,$this->timeCol INTEGER NOT NULL); CREATE INDEX{$this->table}_{$this->timeCol}_idx ON$this->table  ($this->timeCol); COMMIT";

BEGIN; CREATE TABLE sessions (sess_idTEXTNOT NULLPRIMARY KEY, sess_data BLOBNOT NULL, sess_timeINTEGERNOT NULL); CREATE INDEX sessions_sess_time_idxON sessions (sess_time);COMMIT;

PgSQL

$sql ="BEGIN; CREATE TABLE$this->table ($this->idCol VARCHAR(128) NOT NULL PRIMARY KEY,$this->dataCol BYTEA NOT NULL,$this->timeCol INTEGER NOT NULL); CREATE INDEX{$this->table}_{$this->timeCol}_idx ON$this->table ($this->timeCol); COMMIT"

BEGIN; CREATE TABLE sessions (sess_idVARCHAR(128)NOT NULLPRIMARY KEY, sess_dataBYTEANOT NULL, sess_timeINTEGERNOT NULL); CREATE INDEX sessions_sess_time_idxON sessions (sess_time);COMMIT

Anyone have any insight into the proper syntax for theoci andsqlsrv drivers?

Calling out again to see if anyone has knowledge of and/or access to an Oracle (oci driver) or MSSQL Server (sqlsrv driver); we still need to add indexes to theCREATE TABLE statements for these drivers, as has been done for themysql,sqlite, andpgsql drivers already.

ping@robfrawley

#21857 (comment):

Calling out again to see if anyone has knowledge of and/or access to an Oracle (oci driver) or MSSQL Server (sqlsrv driver); we still need to add indexes to the CREATE TABLE statements for these drivers, as has been done for the mysql, sqlite, and pgsql drivers already.

Otherwise, I need to amend a few things per some comments/reviews, but the above is a blocker for me ATM, as I have no experience using theoci andsqlsrv drivers, and no access to these databases to test, either.

@robfrawley is this really a blocker? I mean: if we are index-less in this iteration, it's fine to me, the code would still be better than today for many ppl, and not worse for oci/sqlsrv, isn't it? WOuld you have time to rebase/finish by the end of the week?

@nicolas-grekas If you don't consider it a blocker to only support indexes on select drivers, I'm happy to rebase and address any remaining comments. Doing so by the end of the week shouldn't be an issue, either.

@robfrawley looking forward to it thanks :)

ping@robfrawley, this might be moved to 4.1 very soon :)

I'm moving this PR to 4.1, we're already late in feat freeze.

@robfrawley Still interested in finishing this one? For the record, I agree with@nicolas-grekas about support for OCI and mssql.

@nicolas-grekas@fabpot Fair enough. I can definitely finish this up without index support for oci/sqlsrv. I'll take a look at the end of next week. Likely won't get to it sooner.

Anyone willing to take over this one? It's almost finished AFAICR. /cc @symfony/deciders

If nobody is willing to take over this one, I'm going to close it. Might be something we can work on in the upcoming Hackaton.

+1 this would be great to be merged, we have some issues with this as well.

i will take over this one, thanks for your work@robfrawley

Continued in#33169
Thank you@robfrawley!