Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Adding use statement for InvalidArgumentException#21851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
linaori commentedMar 3, 2017
This should not cause a single BC break afaik |
Nyholm commentedMar 3, 2017
You are correct. Technically this is not a BC break. Butstrictly speaking one could believe the intention was |
nicolas-grekas commentedMar 3, 2017
Should we apply this on the lowest supported branch where it goes ? |
Nyholm commentedMar 3, 2017
I think so. But it is your call. That is why I wrote "master" |
linaori commentedMar 3, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think this is more of an "improvement" than a feature or bugfix. Sadly there's no mention of this in the symfony docs/semver. However, I do think it falls under the following:
|
ro0NL commentedMar 3, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
< 3.2 actually throws So for 2.7 you need to update the actual throws as well (https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Translation/Translator.php#L463) Otherwise this could be 3.2 without any BC issue (it's a doc fix, at least for the current implementations ^^). |
Nyholm commentedMar 3, 2017
Thank you@ro0NL. You are correct. So either merge in master or in 3.2 and up. |
fabpot commentedMar 3, 2017
Thank you@Nyholm. |
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes#21851).Discussion----------Adding use statement for InvalidArgumentException| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This is a super minor bugfix. We should tell what InvalidArgumentException we throw. I consider this a bugfix and not a BC break because `Symfony\Component\Translation\Exception\InvalidArgumentException` has always been the intention.Commits-------187f65b Adding use statement for InvalidArgumentException
Nyholm commentedMar 3, 2017
Thank you for merging |
Uh oh!
There was an error while loading.Please reload this page.
This is a super minor bugfix. We should tell what InvalidArgumentException we throw. I consider this a bugfix and not a BC break because
Symfony\Component\Translation\Exception\InvalidArgumentExceptionhas always been the intention.